RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v14]

[Alexey Ivanov]

On Mon, 9 Oct 2023 03:20:17 GMT, Renjith Kannath Pariyangad <duke at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded invalid GUID and clipped description in windows(ID not found in registry). With com initialization library load proper GUID (same as registry).
>> 2. For Play back device always loading proper device GUID irrespective of com Initialization.
>> 
>> Test:
>> Since screen lock and unlock workflow required for reproducing this issue, did coupe of iteration of manual testing post fix and confirmed its resolving the problem.
>> To reconfirm nothing is broken, executed all audio related test cases on test bench post fix and all are green.
>> 
>> Please review the changes and let me know your comments if any.
>> 
>> Regards,
>> Renjith.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Modified condition based or review

Looks good except for the minor nit.

src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp line 187:

> 185:     }
> 186: 
> 187:     HRESULT hr=::CoInitializeEx(NULL, COINIT_MULTITHREADED | COINIT_DISABLE_OLE1DDE);

Suggestion:

    HRESULT hr = ::CoInitializeEx(NULL, COINIT_MULTITHREADED | COINIT_DISABLE_OLE1DDE);

Spaces around the assignment operator.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14898#pullrequestreview-1665102713
PR Review Comment: https://git.openjdk.org/jdk/pull/14898#discussion_r1350694116