RFR: 4365952: Cannot disable JFileChooser

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Oct 10 06:45:09 UTC 2023


On Fri, 6 Oct 2023 05:10:18 GMT, Tejesh R <tr at openjdk.org> wrote:

> Invoking `setEnabled(false)` on an instance of `JFileChooser` the sub-components are unaffected since the sub-components didn't set/unset enabled explicitly. The fix address the issue and sets the Enabled flag to each sub-components. Along with setting the property to each sub components, the action listeners like mouseClick(Double too) and scroll actions has to be processed based on enabled/disabled property similar to other components. Since `JFilechooser` implementation varies based on LookAndFeel, the same had to be taken care for affected LookAndFeel also. 
> Note: `JFrame` being top level container handles frame disable using native method which couldn't be the case for `JFileChooser`. For `showDialog/showOpenDialog/showSaveDialog` the fix could be to set the one the enabled property for created single Dialog. But when an instance of `JFileChooser` is created and added to Frame (Without Dialog been created), disabling the `FileChooser` alone had to be done by handling each sub-components and listeners separately.

We call `enableEvents` in `JFileChooser.setup` so I guess we can call `disableEvents ` logically..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16068#issuecomment-1754503787


More information about the client-libs-dev mailing list