RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v38]
Andy Goryachev
angorya at openjdk.org
Tue Oct 10 14:47:00 UTC 2023
On Mon, 9 Oct 2023 23:24:35 GMT, ScientificWare <duke at openjdk.org> wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>>
>> This is tracked in JBS as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level 4](https://bugs.openjdk.java.net/browse/JDK-8292276)
>>
>> Adds missing color names, defined by CSS Level 4, in CSS.java :
>> CSS Color Module Level 4
>> W3C Candidate Recommendation Snapshot, 5 July 2022
>> [7.1 Named Colors](https://www.w3.org/TR/css-color-4/#named-color)
>>
>> Designed from : [ScientificWare JDK-8292276 : Add named colors from CSS Color Module Level 4](https://github.com/scientificware/jdk/issues/12)
>
> ScientificWare has updated the pull request incrementally with one additional commit since the last revision:
>
> MissingColorNames.java :
> - Rename the color which doesn't belong to CSS-COLOR-4 specification.
src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 1439:
> 1437:
> 1438: private static Map<String, Color> initColorNames() {
> 1439: return Map.ofEntries(
would it make more sense to use a switch statement instead of a static map?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/9825#discussion_r1352674434
More information about the client-libs-dev
mailing list