RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Wed Oct 11 06:21:55 UTC 2023


On Tue, 10 Oct 2023 22:19:51 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - copyright year
>>  - Fix maximumSize, test
>
> src/java.desktop/share/classes/javax/swing/JScrollBar.java line 765:
> 
>> 763:         if (isMinimumSizeSet()) {
>> 764:             return super.getMinimumSize();
>> 765:         }
> 
> This looks like it has potential to cause many compatibility problems.
> I think it better to simply update the Jscrollbar spec on these methods to reflect what JScrollbar does.

OK. Fair enough...Updated the spec of `getMinimumSize ` and `getMaximumSize` to mention this behaviour change as JScrollBar doesn't override `setMinimumSize` and `setMaximumSize`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15325#discussion_r1354147876


More information about the client-libs-dev mailing list