RFR: 8314498: [macos] Transferring File objects to Finder fails [v2]

Alexey Ushakov avu at openjdk.org
Wed Oct 11 11:35:18 UTC 2023


On Wed, 11 Oct 2023 08:00:27 GMT, Andrey Starovoyt <duke at openjdk.org> wrote:

>> Arik Hadas has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   8314498: [macos] Transferring File objects to Finder fails
>>   
>>   Credit goes to JetBrain that fixed it in JetBrainsRuntime (commit 24819d9).
>>   This fix was also cherry-picked to muCommander and was verified on macOS
>>   12.6.8 and macOs 13, on X86_64 and on M1.
>
> Hello! Actually, I don't like the fix:
> 1. It was the first time I touched Objective-C code, so the code itself is very poor. 
> 2. I didn't add any tests because I am not familiar with the test framework. 
> 3. At some point we received a number of exception reports related to my changes (most-likely), and I have no clue what was the reason. We did some investigation with @avu but unsuccessfully. 
> 
> So, my hope was that someone more experienced will handle the problem properly, but passed three years...
> 
> @avu Can you help to handle submitting the PR from our side?

@anstarovoyt thanks for the update. Yes, we'll handle it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15980#issuecomment-1757481155


More information about the client-libs-dev mailing list