RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v8]

[Alexander Zuev]

On Tue, 26 Sep 2023 11:12:08 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> The issue exist only for non-editable combobox and the root cause is accessible object is not created due to incorrect index returned from component class which results in no a11y API invoked.
>> 
>> Proposed solution is to return the correct accessible child from getAccessibleChild method which is AquaComboBoxButton (arrowButton) instance and that results in invoking the a11y APIs to return the current selected item in combobox. 
>> 
>> Further when the application comes up first time the accessible name is not set for current displayed item in JCombobox that is handled in AquaComboBoxButton which will take care for the current selected item as well as if user modifies the selection by drop-down list.
>> 
>> CI link is posted in JBS.
>
> Abhishek Kumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - AccessibleName set in Listener
>  - Master
>  - Revert BasicComboBoxUI fix and update review comment
>  - bugid removed in comments
>  - Add condition to check JLabel instance
>  - set accessiblename to displayed text in JComboBox
>  - Merge
>  - Explicit frame dispose remove
>  - merge
>  - Review comment update
>  - ... and 1 more: https://git.openjdk.org/jdk/compare/0346af54...1a48076b

Looks good now.

-------------

Marked as reviewed by kizune (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14497#pullrequestreview-1674502075