RFR: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM

Phil Race prr at openjdk.org
Thu Oct 12 18:38:14 UTC 2023


On Thu, 12 Oct 2023 17:54:07 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> As a workaround changing the method that filters out valid resolutions to not allow resolutions unsupported by Apple m1/m2 chips to be reported back to Java side.
> 
> Also removing test from problem list as it should pass again now.

Marked as reviewed by prr (Reviewer).

src/java.desktop/macosx/native/libawt_lwawt/awt/CGraphicsDevice.m line 65:

> 63:     // Workaround for apple bug FB13261205, since it only affects arm based macs
> 64:     // and arm support started with macOS 11 ignore the workaround for previous versions
> 65:     if (@available(macOS 11, *)) {

FYI there's a PR out to make macos 11 the minimum for JDK 22
https://github.com/openjdk/jdk/pull/16155, but this check would be needed in any backport.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16169#pullrequestreview-1674892814
PR Review Comment: https://git.openjdk.org/jdk/pull/16169#discussion_r1357241286


More information about the client-libs-dev mailing list