RFR: JDK-8294090 : Aligns the CSS <rgb()> and <rgba()> function behaviours [v3]
ScientificWare
duke at openjdk.org
Thu Oct 12 22:10:32 UTC 2023
On Wed, 20 Sep 2023 19:54:01 GMT, Phil Race <prr at openjdk.org> wrote:
>> ScientificWare has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>>
>> - Merge branch 'scientificware-patch-004-CSS-aligns_rgb_and_rgba_function_behaviours' of github.com:scientificware/jdk into scientificware-patch-004-CSS-aligns_rgb_and_rgba_function_behaviours
>> - Merge branch 'openjdk:master' into scientificware-patch-004-CSS-aligns_rgb_and_rgba_function_behaviours
>> - Merge master
>> - RGBandRGBAalignmentBehaviours.java :
>> - Change list name.
>> - CSS.java :
>> - Adds a comment about consecutive non space separators.
>> - Adds e uppercase test.
>>
>> RGBandRGBAalignmentBehaviours.java :
>> - Adds test cases with uppercase e.
>> - Merge master
>> - 8294090 : Corrects RGBandRGBAalignmentBehaviours.java file permission.
>> - 8294090 :
>>
>> CSS.java :
>> - Adds links to CSS-COLOR-4 and CSS-VALUE-4 specifications.
>> - Update PARSE RGB method comments.
>> - Adds base-ten exponent support.
>>
>> RGBandRGBAalignmentBehaviours.java :
>> - Adds a set of tests for RGB functions.
>> - Merge master
>>
>> # Conflicts:
>> # src/java.desktop/share/classes/javax/swing/text/html/CSS.java
>> - Amélioration de la prise en charge des fonctions rgb et rgba concernant les couleurs.
>
> src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 1458:
>
>> 1456: * </a> specifications.
>> 1457: * By example <code>rgb(rc gc bc)</code>,
>> 1458: * <code>rgb(rc,gc,bc)</code>, <code>rgb(rc gc bc / ac)</code>,
>
> For many years javadoc has preferred {@code rgb(rc,gc,bc)} instead of <code> .... </code>
>
> Since this comment is being updated existing and new cases should be converted.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15262#discussion_r1357492118
More information about the client-libs-dev
mailing list