RFR: 8318023: Implement IPP output-bin attribute extension on macOS [v2]

Alexander Scherbatiy alexsch at openjdk.org
Wed Oct 18 17:36:52 UTC 2023


On Tue, 17 Oct 2023 20:28:20 GMT, Phil Race <prr at openjdk.org> wrote:

> Why did you file a new RFE when you know about the existing one ? Close your new one as a dup. and redirect everything to the existing one. Also I don't see any UI work to enhance the dialog so it can be selected. And why restrict it to macOS ? Is it an issue of testing ?

My idea was to use JDK-8314070 as an umbrella and provide fixes for macOS, Linux, and Windows separately.   While the OutputBin public API is not fixed any change in it would require to re-test the fix on all 3 platforms.
The fix for the UI dialog requires an additional test with a printer dialog so there would be 2 tests for each platform for re-testing for each essential change in the fix.

> src/java.desktop/share/classes/javax/print/attribute/standard/OutputBin.java line 47:
> 
>> 45:  * <b>IPP Compatibility:</b> The category name returned by {@code getName()} is
>> 46:  * the IPP attribute name. The {@code toString()} method returns the IPP
>> 47:  * string representation of the attribute value.
> 
> I think this needs to mention that it is an IPP extension attribute, meaning not a standard one
> For example like here
> https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/javax/print/attribute/standard/PresentationDirection.html

The javadoc is updated to

 * <b>IPP Compatibility:</b> This attribute is not an IPP 1.1 attribute; it is
 * an attribute in the "output-bin" attribute extension
 * (<a href="https://ftp.pwg.org/pub/pwg/candidates/cs-ippoutputbin10-20010207-5100.2.pdf">
 * PDF</a>) of IPP 1.1. The category name returned by {@code getName()} is the
 * IPP attribute name. The enumeration's integer value is the IPP enum value.
 * The {@code toString()} method returns the IPP string representation of the
 * attribute value.

and `@Override` annotations are added to `OutputBin` and `CustomOutputBin` methods.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16166#issuecomment-1768991703
PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1364254788


More information about the client-libs-dev mailing list