RFR: 4365952: Cannot disable JFileChooser [v4]

Tejesh R tr at openjdk.org
Fri Oct 20 06:50:36 UTC 2023


On Fri, 20 Oct 2023 06:06:23 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Doc update
>
> test/jdk/javax/swing/JFileChooser/FileChooserDisableTest.java line 94:
> 
>> 92:                 String currentDirectory = jfc.getCurrentDirectory().toString();
>> 93:                 if (!currentDirectory.equals(defaultDirectory)) {
>> 94:                     throw new RuntimeException("File chooser disable failed");
> 
> Better to add the failed LAF name also while throwing exception.

I've added print statement mentioning LAF name at line 72. I hope that would be fine?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16068#discussion_r1366545286


More information about the client-libs-dev mailing list