RFR: 4365952: Cannot disable JFileChooser [v5]

Tejesh R tr at openjdk.org
Fri Oct 20 06:59:12 UTC 2023


> Invoking `setEnabled(false)` on an instance of `JFileChooser` the sub-components are unaffected since the sub-components didn't set/unset enabled explicitly. The fix address the issue and sets the Enabled flag to each sub-components. Along with setting the property to each sub components, the action listeners like mouseClick(Double too) and scroll actions has to be processed based on enabled/disabled property similar to other components. Since `JFilechooser` implementation varies based on LookAndFeel, the same had to be taken care for affected LookAndFeel also. 
> Note: `JFrame` being top level container handles frame disable using native method which couldn't be the case for `JFileChooser`. For `showDialog/showOpenDialog/showSaveDialog` the fix could be to set the one the enabled property for created single Dialog. But when an instance of `JFileChooser` is created and added to Frame (Without Dialog been created), disabling the `FileChooser` alone had to be done by handling each sub-components and listeners separately.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16068/files
  - new: https://git.openjdk.org/jdk/pull/16068/files/0b1ba9ad..4773effd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16068&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16068&range=03-04

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/16068.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16068/head:pull/16068

PR: https://git.openjdk.org/jdk/pull/16068


More information about the client-libs-dev mailing list