RFR: 8169475 : WheelModifier.java fails by timeout

Dmitry Markov dmarkov at openjdk.org
Fri Oct 20 10:17:36 UTC 2023


On Fri, 20 Oct 2023 06:59:17 GMT, Renjith Kannath Pariyangad <duke at openjdk.org> wrote:

> Hi Reviewers,
> 
> I have added additional CountDownLatch for making sure button is visible before proceeding,(observe this was one of the key reason for failure) so this helps to improve test case stability. Modified _await()_ function by adding 1sec timeout with exception, this will help to reduce total execution time in case of failure. 
> Please review and let me know your suggestions, if any.

Changes requested by dmarkov (Reviewer).

test/jdk/java/awt/event/MouseWheelEvent/WheelModifier/WheelModifier.java line 173:

> 171:             test.run();
> 172:         } finally {
> 173:             SwingUtilities.invokeAndWait(test.f::dispose);

It would be good to ensure that f is not NULL before dispose.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16281#pullrequestreview-1689703885
PR Review Comment: https://git.openjdk.org/jdk/pull/16281#discussion_r1366771220


More information about the client-libs-dev mailing list