RFR: JDK-8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes

[Damon Nguyen]

On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès <lbourges at openjdk.org> wrote:

> For stroked shapes (no Renderer use), the min-join-error check is disabled.
> Added new jtreg test to verify join using pixel counts

Changes look reasonable and the test looks good. Ran it myself and it passes with the changes.

test/jdk/sun/java2d/marlin/TestCreateStrokedShapeJoins.java line 39:

> 37:  */
> 38: public class TestCreateStrokedShapeJoins {
> 39: 

Suggestion:


/*
 * @test
 * @bug 8316741
 * @summary Verifies that Marlin renderer's Stroker generates properly joins
 * in createStrokedShape()
 * @run main TestCreateStrokedShapeJoins
 */
 
public class TestCreateStrokedShapeJoins {

test/jdk/sun/java2d/marlin/TestCreateStrokedShapeJoins.java line 44:

> 42:     private final static int W = 200;
> 43: 
> 44:     private final static int[] REF_COUNTS = new int[]{4561, 4790, 5499};

Suggestion:

    private final static int[] REF_COUNTS = new int[] {4561, 4790, 5499};

test/jdk/sun/java2d/marlin/TestCreateStrokedShapeJoins.java line 47:

> 45: 
> 46:     public static void main(String[] args) throws Exception {
> 47:         final int[] test = new int[]{

Suggestion:

        final int[] test = new int[] {

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/16002#pullrequestreview-1690675540
PR Review Comment: https://git.openjdk.org/jdk/pull/16002#discussion_r1367348124
PR Review Comment: https://git.openjdk.org/jdk/pull/16002#discussion_r1367379410
PR Review Comment: https://git.openjdk.org/jdk/pull/16002#discussion_r1367379573