RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v39]
ScientificWare
duke at openjdk.org
Mon Oct 23 18:09:51 UTC 2023
On Fri, 13 Oct 2023 07:50:17 GMT, ScientificWare <duke at openjdk.org> wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>>
>> This is tracked in JBS as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level 4](https://bugs.openjdk.java.net/browse/JDK-8292276)
>>
>> Adds missing color names, defined by CSS Level 4, in CSS.java :
>> CSS Color Module Level 4
>> W3C Candidate Recommendation Snapshot, 5 July 2022
>> [7.1 Named Colors](https://www.w3.org/TR/css-color-4/#named-color)
>>
>> Designed from : [ScientificWare JDK-8292276 : Add named colors from CSS Color Module Level 4](https://github.com/scientificware/jdk/issues/12)
>
> ScientificWare has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 59 commits:
>
> - Merge master
> - CSS.java :
> - Update source code declaration in documentation comments and specifications.
> - Typo in an argument.
> - MissingColorNames.java :
> - Catches the Color Illegal Argument Exception and appends it to the result summary.
> - Uncomments rgb tests.
> - MissingColorNames.java :
> - Rename the color which doesn't belong to CSS-COLOR-4 specification.
> - Merge master
> - MissingColorNames.java :
> - Add a subset of RGB and RGBA tests.
> - MissingColorNames.java :
> - rename the list of string test.
>
> CSS.java :
> - correct a wrong index.
> - MissingColorNames.java : Adds a subset of hexadecimal tests.
> - Merge scientificware-patch-003-CSS-add_4_8_digits_hex_coded_color
>
> # Conflicts:
> # src/java.desktop/share/classes/javax/swing/text/html/CSS.java
> - Merge master
> - ... and 49 more: https://git.openjdk.org/jdk/compare/1082c0e7...9898fedf
Actually, JDK-8294090 https://github.com/openjdk/jdk/pull/15262 successfully parses expressions like `rgba(12 24 200%)` but the CSS spec doesn't allow mixing numbers and percentages in R, G and B components. I am correcting this.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/9825#issuecomment-1775738789
More information about the client-libs-dev
mailing list