RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v3]
Phil Race
prr at openjdk.org
Tue Oct 24 18:06:32 UTC 2023
On Mon, 23 Oct 2023 20:40:14 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> This enhances the `Builder` pattern added in [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method `testUI` which allows passing a lambda expression or a method reference to create *the test UI window*.
>>
>> The `PassFailJFrame` will automatically call the method on the EDT to create the UI, add it to the internal list of windows, install the window closing listener and finally position and show both the instructions and test UI.
>>
>> Alternatively, you can pass an already created window.
>>
>> The `main` method of a manual test could look as simple as a sequence of calls:
>>
>>
>> public static void main(String[] args) throws Exception {
>> PassFailJFrame.builder()
>> .instructions(INSTRUCTIONS)
>> .testUI(() -> createTestUI())
>> .build()
>> .awaitAndCheck();
>> }
>>
>> where `createTestUI` returns a test UI window.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>
> Add instructions on how to use PassFailJFrame
Marked as reviewed by prr (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/15665#pullrequestreview-1695556451
More information about the client-libs-dev
mailing list