RFR: 8316017: Refactor timeout handler in PassFailJFrame [v2]

Phil Race prr at openjdk.org
Tue Oct 24 18:12:32 UTC 2023


On Tue, 24 Oct 2023 11:04:52 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Refactored timeout handling in PassFailJFrame:
>> 
>> 1. Managing the timer and formatting the time left is inside `TimeoutHandler` class.
>> 2. The class handles timer events and updates the label accordingly.
>> 
>> This is implemented on top of #15665.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refactor failure reason
>   
>   Ensure the failure reason doesn't change after it's set.
>   Removed 'failed' and 'timeout' fields:
>   if failureReason is set, the test fails.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/15668#pullrequestreview-1695573011


More information about the client-libs-dev mailing list