RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]

Alexey Ivanov aivanov at openjdk.org
Tue Oct 24 19:21:30 UTC 2023


On Tue, 24 Oct 2023 19:04:05 GMT, ScientificWare <duke at openjdk.org> wrote:

>>> > What purpose does this distinction serve?
>>> 
>>> Definitely an application developer and because it's the context of this HTML implementation, may I preserve this distinction ?
>> 
>> Okay, let it be. However, I still think it's not the right thing.
>> 
>> There was nothing else but the `src` attribute, now there is.
>> 
>>> > This actually raises another question: what if altAtt isn't provided? Should it fallback to srcURL?
>>> 
>>> Yes, it's a logical error on my part.
>> 
>> Are you going to address it?
>
> ![image](https://github.com/openjdk/jdk/assets/19194678/0c4ba14d-84df-4c45-abb2-f3f9dca01bd2)
> 
> 
> 
>             <html>
>                 <body>
>                     <input type=image name=point src="file:oracle_logo_50x50.jpg" alt="Logo Oracle JPG">
>                     <p>
>                     <input type=image name=point src="file:oracle_logo_50x50.jpg">
>                     <p>
>                     <input type=image name=point src="file:none_oracle_logo_50x50.jpg" alt="Logo Oracle JPG">
>                     <p>
>                     <input type=image name=point src="file:none_oracle_logo_50x50.jpg">
>                     <p>
>                     <input type=image name=point src="files:none_oracle_logo_50x50.jpg" alt="Logo Oracle JPG">
>                     <p>
>                     <input type=image name=point src="files:none_oracle_logo_50x50.jpg">
>                     <p>
>                 </body>
>             </html>
> 
> 
> - Left before the Patch
> - Right with your suggestion and if the distinction is preserved.

Yes, that's what I meant.

A button with the plain source is better than a button without a title at all.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15319#discussion_r1370710100


More information about the client-libs-dev mailing list