RFR: 8305321: Remove unused exports in java.desktop [v5]
Daniel Jeliński
djelinski at openjdk.org
Thu Oct 26 06:15:45 UTC 2023
On Wed, 25 Oct 2023 23:23:19 GMT, Phil Race <prr at openjdk.org> wrote:
>> Daniel Jeliński has updated the pull request incrementally with seven additional commits since the last revision:
>>
>> - Revert "Remove Color_initIDs"
>>
>> This reverts commit 8a8c9a63de14773905a64a8067ddd68c8a6ab137.
>> - Revert "Remove KeyboardFocusManager_initIDs"
>>
>> This reverts commit 66bd9a136b4c34d7d600ad49ce67fcd060160fb8.
>> - Revert "Remove Rectangle_initIDs"
>>
>> This reverts commit 0d21e361cd92215bbc8bb971b5c3f26898b96a0b.
>> - Revert "Remove Button_initIDs"
>>
>> This reverts commit 423afbf3b61cad504ae10a99ceb02c318f3a83ae.
>> - Revert "Remove FileDialog_initIDs"
>>
>> This reverts commit e66a9ffdda6e451c4298f59786adbd434dd1adb5.
>> - Revert "Remove TextField_initIDs"
>>
>> This reverts commit 0c3b78d27b899d4301f8326f90f1cc36703cbd3d.
>> - Revert "Update copyright"
>>
>> This reverts commit 5808c65e5fbabc08b43da982736b40db87000cb5.
>
> src/java.desktop/share/native/common/font/sunfontids.h line 86:
>
>> 84:
>> 85: /* Note: we share variable in the context of fontmanager lib
>> 86: but we need access method to use it from separate rasterizer lib */
>
> That comment had nothing to do with the rasterizer OpenJDK project which wasn't even about font rasterisation. I think this refers to the closed source font rasteriser now removed. Anyway I don't think the comment is important enough to insist on keeping it.
good to know, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13261#discussion_r1372632269
More information about the client-libs-dev
mailing list