RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v7]

Alexey Ivanov aivanov at openjdk.org
Fri Sep 1 10:22:49 UTC 2023


On Fri, 1 Sep 2023 09:18:09 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java line 253:
>> 
>>> 251: 
>>> 252:         // set the accessible name to the displayed text in JComboBox.
>>> 253:         // screen magnifier queries to get the accessible name to display magnified text.
>> 
>> I still do not think that setting accessible name in paint is a good idea. Setting it during the initialization and adding a property change listener to the accessible context to track changes seems like a better way to do it.
>
> Ok, I will check this.

> I still do not think that setting accessible name in paint is a good idea.

It's been my biggest concern. But I didn't even think about it this way.

The problem is that the displayed value is known only when the component is painted. Other components seem to handle it… somehow.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1312851560


More information about the client-libs-dev mailing list