RFR: 8258970: Disabled JPasswordField foreground color is wrong with GTK LAF [v4]

Abhishek Kumar abhiscxk at openjdk.org
Fri Sep 1 11:39:45 UTC 2023


> Disabled JPasswordField foreground color was not grayed out in GTK LAF.
> 
> The foreground color in disabled state was close to black color (RGB 0,0,0) for password field which is not differentiable from enabled state foreground color.
> 
> To fix for this problem, the widget type is changed to `TEXT_AREA `for disable password field which returns the foreground color as gray. Checked with Oracle linux as well and fix worked fine.
> 
> An automated test case has been added and checked in CI, link is added in JBS. Test mentioned in JBS also works fine with the fix.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  condition clubbed together

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15263/files
  - new: https://git.openjdk.org/jdk/pull/15263/files/25591d1d..c48eed64

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15263&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15263&range=02-03

  Stats: 5 lines in 1 file changed: 0 ins; 1 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/15263.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15263/head:pull/15263

PR: https://git.openjdk.org/jdk/pull/15263


More information about the client-libs-dev mailing list