RFR: 8258970: Disabled JPasswordField foreground color is wrong with GTK LAF [v3]

[Abhishek Kumar]

On Fri, 1 Sep 2023 11:21:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment update
>
> src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c line 2409:
> 
>> 2407:                 } else if (state_type == GTK_STATE_INSENSITIVE && color_type == TEXT_FOREGROUND) {
>> 2408:                     widget_type = TEXT_AREA;
>> 2409:                 }
> 
> I think there's no need of another else if
> It can be just
> 
> if ((state_type == GTK_STATE_SELECTED && color_type == TEXT_BACKGROUND)) ||
>     (state_type == GTK_STATE_INSENSITIVE && color_type == TEXT_FOREGROUND)) {
>   widget_type =TEXT_AREA:

> 

Yeah, that's correct. Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15263#discussion_r1312915885