RFR: 8312075: FileChooser.win32.newFolder is not updated when changing Locale [v7]

Alexey Ivanov aivanov at openjdk.org
Fri Sep 1 13:17:42 UTC 2023


On Fri, 1 Sep 2023 13:03:40 GMT, Tejesh R <tr at openjdk.org> wrote:

>> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`. Converting the `String `to `locale` before adding as command key fix the issue. 
>> I have verified the test in all other platforms and Look and Feel which has option to create New Folder, results were fine. No regressions found on CI system with the fix. Added manual test to verify the fix.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review fix

Looks good to me.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15069#pullrequestreview-1606930631


More information about the client-libs-dev mailing list