RFR: 8258970: Disabled JPasswordField foreground color is wrong with GTK LAF [v4]

Tejesh R tr at openjdk.org
Fri Sep 1 15:26:42 UTC 2023


On Fri, 1 Sep 2023 11:39:45 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Disabled JPasswordField foreground color was not grayed out in GTK LAF.
>> 
>> The foreground color in disabled state was close to black color (RGB 0,0,0) for password field which is not differentiable from enabled state foreground color.
>> 
>> To fix for this problem, the widget type is changed to `TEXT_AREA `for disable password field which returns the foreground color as gray. Checked with Oracle linux as well and fix worked fine.
>> 
>> An automated test case has been added and checked in CI, link is added in JBS. Test mentioned in JBS also works fine with the fix.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   condition clubbed together

Looks Good to Me.

-------------

Marked as reviewed by tr (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15263#pullrequestreview-1607173968


More information about the client-libs-dev mailing list