RFR: 8315584 : java/awt/print/Dialog/DialogType.java fails with option not supported: yesno

[Harshitha Onkar]

On Sun, 3 Sep 2023 22:12:49 GMT, lawrence.andrews <duke at openjdk.org> wrote:

> Test was failing with "test result: Error. Parse Exception: Arguments to `manual' option not supported: yesno"
> Following are fixed 
> 1) Removed yesno 
> 2) Used PassFailJFrame manual test framework to show the test instruction & allow the user to decide test execution result.
> 3) Added SkippedException in case Printer is not configured on the test host.
> 4) Updated the instruction how to close the print dialog that test is showing to the user.
> 5) Added an extra line to the file that was missing.

test/jdk/java/awt/print/Dialog/DialogType.java line 26:

> 24: import java.awt.print.PrinterJob;
> 25: import java.lang.reflect.InvocationTargetException;
> 26: import javax.print.attribute.Attribute;

Unused imports can be removed

test/jdk/java/awt/print/Dialog/DialogType.java line 52:

> 50:             Two dialogs are shown in succession.,
> 51:             The test passes as long as no exceptions are thrown, *AND*,
> 52:             if running on Windows only, the first dialog is a native windows,

comma is not necessary at certain places in the instructions section and can be removed here  -  "when using new API," "native windows," and "are shown in succession.,"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15554#discussion_r1316557563
PR Review Comment: https://git.openjdk.org/jdk/pull/15554#discussion_r1316557073