RFR: 8315606: Open source few swing text/html tests [v2]
Alexey Ivanov
aivanov at openjdk.org
Wed Sep 6 12:32:39 UTC 2023
On Wed, 6 Sep 2023 10:25:27 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Few closed swing text/html tests are opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comment fix
Except for the minor formatting.
test/jdk/javax/swing/text/html/ImageView/bug4329185.java line 30:
> 28: * @key headful
> 29: * @run main bug4329185
> 30: */
Suggestion:
* @run main bug4329185
*/
test/jdk/javax/swing/text/html/InlineView/bug4623342.java line 29:
> 27: @key headful
> 28: @run main bug4623342
> 29: */
Suggestion:
/*
* @test
* @bug 4623342
* @summary Tests if InlineView causes extra spacing around images in JTable
* @key headful
* @run main bug4623342
*/
To be consistent with other tests.
-------------
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15580#pullrequestreview-1613209653
PR Review Comment: https://git.openjdk.org/jdk/pull/15580#discussion_r1317202880
PR Review Comment: https://git.openjdk.org/jdk/pull/15580#discussion_r1317205662
More information about the client-libs-dev
mailing list