RFR: 8313348: Fix typo in JFormattedTextField: 'it self' [v2]
Alexey Ivanov
aivanov at openjdk.org
Thu Sep 7 10:26:44 UTC 2023
On Tue, 8 Aug 2023 00:42:36 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
> That is wrong suggestion, if the one bug found in one place it is part of the fixing process to check that it does not exists in another one. Especially for typo it is easy to check.
I don't think it is wrong, especially for typos. As I said, fixing typos in the entire code base, even if limited to the `java.desktop` module requires *considerable* amount of time. Yet fixing a typo in a certain file is a *trivial fix* which is easy to fix and is quick to review.
> We already discussed this for one issue in scrollbars on windows, where the same bug was missed in the similar place.
In that case, the problem could be more serious. As I [explained](https://github.com/openjdk/jdk/pull/14338#issuecomment-1581491086) in PR #14338, I missed this function was used in another component. At the same time, no test case has been found where functionality of ScrollBar is affected.
I have submitted [the follow-up issues](https://github.com/openjdk/jdk/pull/14338#issuecomment-1706567768) to clean it up.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15087#discussion_r1318402637
More information about the client-libs-dev
mailing list