RFR: 8314755: Resource leak: SwingWorker listener keeps strong reference to executor [v4]

Christopher Sahnwaldt duke at openjdk.org
Tue Sep 12 12:34:12 UTC 2023


> In https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32 the weak reference was accidentally changed from a field to a local variable, which means that the PropertyChangeListener keeps a strong reference to executorService, which is a resource leak

Christopher Sahnwaldt has updated the pull request incrementally with one additional commit since the last revision:

  SwingWorkerExecutorLeakTest.java: use AppContext.getAppContext() instead of SunToolkit.createNewAppContext() to create AppContext, set necessary system properties

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15081/files
  - new: https://git.openjdk.org/jdk/pull/15081/files/e51b49cf..06cbac9e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15081&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15081&range=02-03

  Stats: 19 lines in 1 file changed: 16 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/15081.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15081/head:pull/15081

PR: https://git.openjdk.org/jdk/pull/15081


More information about the client-libs-dev mailing list