RFR: 8315834: Open source several Swing JSpinner related tests

[Prasanta Sadhukhan]

On Tue, 12 Sep 2023 05:46:23 GMT, Tejesh R <tr at openjdk.org> wrote:

> Open source these Swing JSpinner related tests:
> 
> javax/swing/JSpinner/4522737/bug4522737.java
> javax/swing/JSpinner/4656590/bug4656590.java
> javax/swing/JSpinner/4680204/bug4680204.java
> javax/swing/JSpinner/4862257/bug4862257.java
> javax/swing/JSpinner/5104421/bug5104421.java

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/javax/swing/JSpinner/bug4522737.java line 51:

> 49:                 objectOutputStream = new ObjectOutputStream(byteArrayOutputStream);
> 50:                 objectOutputStream.writeObject(originalComponent);
> 51:             } catch (Throwable e) {

You can remove this try-catch block and let original exception propagate

test/jdk/javax/swing/JSpinner/bug4680204.java line 65:

> 63:                 frame.getContentPane().add(sp2);
> 64:                 sp2.setModel(new SpinnerNumberModel(1, 1, 100, 1));
> 65:                 frame.pack();

Probably setLocationRelativeTo call would be good

-------------

PR Review: https://git.openjdk.org/jdk/pull/15678#pullrequestreview-1623787651
PR Review Comment: https://git.openjdk.org/jdk/pull/15678#discussion_r1324033900
PR Review Comment: https://git.openjdk.org/jdk/pull/15678#discussion_r1324036078