RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v2]
Alexey Ivanov
aivanov at openjdk.org
Wed Sep 13 18:54:39 UTC 2023
On Tue, 12 Sep 2023 19:51:45 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>>> However, to test this case I'll need a (simple) scenario where multiple windows are created.
>>
>> For example `test/jdk/java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_2.java` is not converted to use PassFailJFrame, but shows instruction window and two test windows.
>>
>> For these test windows, we can safely reduce the width a lot and arrange them in a row.
>> 
>>
>> Probably we could add some other sophisticated layouts later, e.g.:
>> 
>>
>> But this kind of layout seems to be beyond the scope of this PR, I just wish we hadn't missed the option to add multiple windows at once.
>
> But laying out the test windows is really a problem. With one window, the framework already provides a way to position the window, it is applied to the primary test window.
>
> Before showing other windows, they need to be positioned.
>
> There could be a callback so that the test developer is able to position the windows. In the future, we may add simple layouts to perform this task automatically.
>
>> But this kind of layout seems to be beyond the scope of this PR, I just wish we hadn't missed the option to add multiple windows at once.
>
> I agree, it's better to implement it right away. I didn't think about it as viable solution because of positioning issues.
It is possible to lay out test windows like this:

-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15665#discussion_r1324935857
More information about the client-libs-dev
mailing list