RFR: 8315669: Open source several Swing PopupMenu related tests
Damon Nguyen
dnguyen at openjdk.org
Thu Sep 14 21:51:39 UTC 2023
On Wed, 13 Sep 2023 09:19:27 GMT, Tejesh R <tr at openjdk.org> wrote:
> Open source these Swing PopupMenu related tests:
>
> javax/swing/JPopupMenu/4236750/bug4236750.java
> javax/swing/JPopupMenu/4321273/bug4321273.java
> javax/swing/JPopupMenu/4711693/bug4711693.java
> javax/swing/JPopupMenu/4962731/bug4962731.java
> javax/swing/JPopupMenu/4966109/bug4966109.java
> javax/swing/JPopupMenu/5091257/bug5091257.java
Looks fine to me. One minor nit capitalization inconsistency
test/jdk/javax/swing/JPopupMenu/bug4711693.java line 123:
> 121: throw new RuntimeException("Test failed. Popup disposed on mouse release.");
> 122: } else {
> 123: System.out.println("test Passed!");
Suggestion:
System.out.println("Test Passed!");
-------------
Marked as reviewed by dnguyen (Committer).
PR Review: https://git.openjdk.org/jdk/pull/15704#pullrequestreview-1627798019
PR Review Comment: https://git.openjdk.org/jdk/pull/15704#discussion_r1326549091
More information about the client-libs-dev
mailing list