RFR: 8316104: Open source several Swing SplitPane and RadioButton related tests

Tejesh R tr at openjdk.org
Fri Sep 15 11:45:42 UTC 2023


On Fri, 15 Sep 2023 06:48:17 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Do we need to add auto delay also for the tests? `robot.setAutoDelay(100);`

I don't think its mandatory, no keyboard events are there here.

> test/jdk/javax/swing/JRadioButton/bug4823809.java line 52:
> 
>> 50:             robot = new Robot();
>> 51:             SwingUtilities.invokeAndWait(() -> {
>> 52:                 frame = new JFrame();
> 
> Please add frame title.

It wont be visible, no point in adding title.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15738#issuecomment-1721138402
PR Review Comment: https://git.openjdk.org/jdk/pull/15738#discussion_r1327174036


More information about the client-libs-dev mailing list