RFR: JDK-8315876 Open source several Swing CSS related tests

Damon Nguyen dnguyen at openjdk.org
Fri Sep 15 21:57:41 UTC 2023


On Fri, 15 Sep 2023 19:35:15 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following tests are open sourced as part of this PR.
> 
> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
> 4. test/jdk/javax/swing/text/html/CSS/bug4764897.java
> 5. test/jdk/javax/swing/text/html/HTMLDocument/bug4209280.java

LGTM. Minor spacing nit

test/jdk/javax/swing/text/html/CSS/bug4174871.java line 78:

> 76:         frame = new JFrame("Table CellSpacing Test");
> 77:         frame.getContentPane().add(pane);
> 78:         frame.setSize(600,200);

Suggestion:

        frame.setSize(600, 200);

test/jdk/javax/swing/text/html/CSS/bug4174874.java line 78:

> 76:         frame = new JFrame("Table Border Test");
> 77:         frame.getContentPane().add(pane);
> 78:         frame.setSize(600,200);

Suggestion:

        frame.setSize(600, 200);

test/jdk/javax/swing/text/html/CSS/bug4284162.java line 82:

> 80: 
> 81:         frame.getContentPane().add(jep);
> 82:         frame.setSize(200,200);

Suggestion:

        frame.setSize(200, 200);

test/jdk/javax/swing/text/html/CSS/bug4764897.java line 81:

> 79:         frame = new JFrame("Table Border Test");
> 80:         frame.getContentPane().add(pane);
> 81:         frame.setSize(600,200);

Suggestion:

        frame.setSize(600, 200);

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15769#pullrequestreview-1629769889
PR Review Comment: https://git.openjdk.org/jdk/pull/15769#discussion_r1327823435
PR Review Comment: https://git.openjdk.org/jdk/pull/15769#discussion_r1327823611
PR Review Comment: https://git.openjdk.org/jdk/pull/15769#discussion_r1327823713
PR Review Comment: https://git.openjdk.org/jdk/pull/15769#discussion_r1327823887


More information about the client-libs-dev mailing list