RFR: 8315883: Open source several Swing JToolbar tests

Harshitha Onkar honkar at openjdk.org
Fri Sep 15 23:06:39 UTC 2023


On Thu, 14 Sep 2023 16:43:29 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> These are the tests being converted:
> 
> javax/swing/JToolBar/4138694/bug4138694.java
> javax/swing/JToolBar/4140421/bug4140421.java
> javax/swing/JToolBar/4196662/bug4196662.java
> javax/swing/JToolBar/4243930/bug4243930.java

LGTM. I suppose all the main() can throw generic Exception

test/jdk/javax/swing/JToolBar/bug4138694.java line 47:

> 45: 
> 46:     public static void main(String[] args) throws InterruptedException,
> 47:             InvocationTargetException {

Suggestion:

    public static void main(String[] args) throws Exception {

-------------

Marked as reviewed by honkar (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15748#pullrequestreview-1629812902
PR Review Comment: https://git.openjdk.org/jdk/pull/15748#discussion_r1327849822


More information about the client-libs-dev mailing list