RFR: 8316056: Open source several Swing JTree tests

Harshitha Onkar honkar at openjdk.org
Fri Sep 15 23:17:37 UTC 2023


On Thu, 14 Sep 2023 21:40:55 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> These are the tests being converted:
> 
> javax/swing/JTree/4210432/bug4210432.java
> javax/swing/JTree/4213868/bug4213868.java
> javax/swing/JTree/4224491/bug4224491.java
> javax/swing/JTree/4237370/bug4237370.java
> javax/swing/JTree/4662505/bug4662505.java

Tests look good.

test/jdk/javax/swing/JTree/bug4213868.java line 44:

> 42:         JTree tree = new JTree(root);
> 43:         for (int i = 1; i < 10; i++) {
> 44:             root.add(new DefaultMutableTreeNode(Integer.valueOf(i)));

Suggestion:

                new DefaultMutableTreeNode(0, true);
        JTree tree = new JTree(root);
        for (int i = 1; i < 10; i++) {
            root.add(new DefaultMutableTreeNode(i));

-------------

Marked as reviewed by honkar (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15756#pullrequestreview-1629828791
PR Review Comment: https://git.openjdk.org/jdk/pull/15756#discussion_r1327853316


More information about the client-libs-dev mailing list