RFR: JDK-8315876 Open source several Swing CSS related tests

Harshitha Onkar honkar at openjdk.org
Mon Sep 18 18:19:40 UTC 2023


On Mon, 18 Sep 2023 10:05:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Following tests are open sourced as part of this PR.
>> 
>> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
>> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
>> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
>> 4. test/jdk/javax/swing/text/html/CSS/bug4764897.java
>> 5. test/jdk/javax/swing/text/html/HTMLDocument/bug4209280.java
>
> test/jdk/javax/swing/text/html/CSS/bug4174871.java line 41:
> 
>> 39:     private static JFrame frame;
>> 40:     private static JTextPane pane;
>> 41:     private static volatile boolean passed = false;
> 
> Explicitly assigning the default value is redundant.
> 
> Moreover, you always assign a value in the `testUI` method.
> 
> This comment also applies to the tests below.

I agree. There are some tests that start with passed as 'true', hence explicitly assigned 'false' to boolean var in these tests even though it is redundant as to add clarity when running the tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15769#discussion_r1329114518


More information about the client-libs-dev mailing list