RFR: 8315804: Open source several Swing JTabbedPane JTextArea JTextField tests [v3]

Damon Nguyen dnguyen at openjdk.org
Mon Sep 18 19:00:53 UTC 2023


On Mon, 18 Sep 2023 12:58:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add original exception
>
> test/jdk/javax/swing/JTextArea/bug4849868.java line 70:
> 
>> 68:                 f.setSize(300, 300);
>> 69:                 f.setVisible(true);
>> 70:                 f.setLocationRelativeTo(null);
> 
> Suggestion:
> 
>                 f.setSize(300, 300);
>                 f.setLocationRelativeTo(null);
>                 f.setVisible(true);

Thanks for catching this

> test/jdk/javax/swing/JTextArea/bug4849868.java line 73:
> 
>> 71:             });
>> 72: 
>> 73:             robot.delay(1000);
> 
> Suggestion:
> 
>             robot.waitForIdle();
>             robot.delay(1000);

Added. thanks

> test/jdk/javax/swing/JTextField/bug4244613.java line 40:
> 
>> 38:     /** Auxilliary class implementing Action
>> 39:     */
>> 40:     static class NullAction implements Action {
> 
> You may extend `AbstractAction` to reduce the amount of methods implemented.

Took your advice. Thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15747#discussion_r1329154180
PR Review Comment: https://git.openjdk.org/jdk/pull/15747#discussion_r1329153650
PR Review Comment: https://git.openjdk.org/jdk/pull/15747#discussion_r1329153861


More information about the client-libs-dev mailing list