RFR: 8315883: Open source several Swing JToolbar tests [v2]
Alexey Ivanov
aivanov at openjdk.org
Mon Sep 18 19:05:43 UTC 2023
On Mon, 18 Sep 2023 18:55:37 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4138694/bug4138694.java
>> javax/swing/JToolBar/4140421/bug4140421.java
>> javax/swing/JToolBar/4196662/bug4196662.java
>> javax/swing/JToolBar/4243930/bug4243930.java
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments update
Marked as reviewed by aivanov (Reviewer).
test/jdk/javax/swing/JToolBar/bug4138694.java line 41:
> 39:
> 40: public class bug4138694 {
> 41: public static final String exampleText = "Action";
Suggestion:
private static final String actionName = "Action";
It fits better this way, but it's unimportant.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15748#pullrequestreview-1631785385
PR Review Comment: https://git.openjdk.org/jdk/pull/15748#discussion_r1329162525
More information about the client-libs-dev
mailing list