RFR: JDK-8315876 Open source several Swing CSS related tests [v2]
Alexey Ivanov
aivanov at openjdk.org
Mon Sep 18 19:14:43 UTC 2023
On Mon, 18 Sep 2023 18:54:39 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Following tests are open sourced as part of this PR.
>>
>> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
>> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
>> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
>> 4. test/jdk/javax/swing/text/html/CSS/bug4764897.java
>> 5. test/jdk/javax/swing/text/html/HTMLDocument/bug4209280.java
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> few review change update
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/text/html/CSS/bug4174871.java line 52:
> 50:
> 51: SwingUtilities.invokeAndWait(bug4174871::testUI);
> 52: robot.waitForIdle();
`waitForIdle` isn't necessary either: the value of `passed` has been set inside, it cannot change — nothing's left to wait for.
It applies to all the tests.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15769#pullrequestreview-1631797824
PR Review Comment: https://git.openjdk.org/jdk/pull/15769#discussion_r1329170948
More information about the client-libs-dev
mailing list