RFR: 8315804: Open source several Swing JTabbedPane JTextArea JTextField tests [v4]

Alexey Ivanov aivanov at openjdk.org
Mon Sep 18 19:17:43 UTC 2023


On Mon, 18 Sep 2023 19:14:42 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> These are the tests being converted:
>> 
>> javax/swing/JTabbedPane/4703690/bug4703690.java
>> javax/swing/JTabbedPane/GetComponentAt/GetComponentAtTest.java
>> javax/swing/JTabbedPane/ReplaceCompTab/ReplaceCompTab.java
>> javax/swing/JTextArea/4849868/bug4849868.java
>> javax/swing/JTextField/4244613/bug4244613.java
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add focus to EDT

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/swing/JTabbedPane/bug4703690.java line 108:

> 106:         robot.setAutoDelay(50);
> 107: 
> 108:         SwingUtilities.invokeAndWait(() -> two.requestFocus());

My preference is using method reference wherever possible, this fixes an IDEA warning. It's up to you though.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15747#pullrequestreview-1631802951
PR Review Comment: https://git.openjdk.org/jdk/pull/15747#discussion_r1329174307


More information about the client-libs-dev mailing list