RFR: 8315952: Open source several Swing JToolbar JTooltip JTree tests [v2]
Harshitha Onkar
honkar at openjdk.org
Tue Sep 19 16:06:42 UTC 2023
On Mon, 18 Sep 2023 19:30:46 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4368050/bug4368050.java
>> javax/swing/JToolBar/4465534/bug4465534.java
>> javax/swing/JToolBar/4700351/bug4700351.java
>> javax/swing/JToolTip/4107843/bug4107843.java
>> javax/swing/JTree/4161685/bug4161685.java
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments updates
test/jdk/javax/swing/JToolBar/bug4368050.java line 48:
> 46: ObjectInputStream ois = new ObjectInputStream(bais)) {
> 47: ois.readObject();
> 48: }
Better to close the stream objects in finally block in case of Exception.
finally {
if (oos != null) {
oos.close();
}
if (ois != null) {
ois.close();
}
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15755#discussion_r1330365805
More information about the client-libs-dev
mailing list