RFR: 8315883: Open source several Swing JToolbar tests [v3]

[Damon Nguyen]

On Tue, 19 Sep 2023 10:17:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update constant name
>
> test/jdk/javax/swing/JToolBar/bug4243930.java line 44:
> 
>> 42:     private static class NullAction extends AbstractAction {
>> 43:         public void actionPerformed(ActionEvent e){}
>> 44:     }
> 
> Suggestion:
> 
>     /**
>      * Auxiliary class implementing Action
>      */
>     private static class NullAction extends AbstractAction {
>         public void actionPerformed(ActionEvent e) {}
>     }
> 
> 
> Align the javadoc to class declaration.
> 
> In a way, the comment is redundant, the purpose is clearly seen from the usage.

Very true. I just removed the comment altogether. Thanks

> test/jdk/javax/swing/JToolBar/bug4243930.java line 47:
> 
>> 45: 
>> 46:     public static void main(String[] argv) throws InterruptedException,
>> 47:             InvocationTargetException {
> 
> Suggestion:
> 
>     public static void main(String[] argv) throws Exception {
> 
> This one hasn't been updated.

Nice catch. Thanks, updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15748#discussion_r1330442754
PR Review Comment: https://git.openjdk.org/jdk/pull/15748#discussion_r1330442111