RFR: 8316306: Open source and convert manual Swing test [v2]

[Damon Nguyen]

On Tue, 19 Sep 2023 00:27:28 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments changes
>
> test/jdk/javax/swing/JToolBar/bug4203039.java line 47:
> 
>> 45:             "installed components on the SOUTH\nand EAST, so verify the " +
>> 46:             "toolbar cannot dock in those\nlocations but can dock on the " +
>> 47:             "NORTH and WEST";
> 
> Suggestion:
> 
>    private static final String instructionsText = """
>             This test is used to verify that application-installed
>             components prevent the toolbar from docking in
>             those locations.
> 
>             This test has installed components on the SOUTH
>             and EAST, so verify the toolbar cannot dock in those
>             locations but can dock on the NORTH and WEST""";
> 
> Use of text block looks cleaner here, eliminates the need of appending `\n` in between.

Thanks for the suggestion, implemented.

> test/jdk/javax/swing/JToolBar/bug4203039.java line 55:
> 
>> 53:                 .testTimeOut(5)
>> 54:                 .rows(10)
>> 55:                 .columns(30)
> 
> Minor cosmetic change.
> 
> Suggestion:
> 
>                 .columns(35)

Updated. 30 was a cleaner look for my device, but the extra space probably looks better for other systems where the sizing may vary slightly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15806#discussion_r1330497870
PR Review Comment: https://git.openjdk.org/jdk/pull/15806#discussion_r1330498584