RFR: 8316149: Open source several Swing JTree JViewport KeyboardManager tests [v2]

Damon Nguyen dnguyen at openjdk.org
Tue Sep 19 19:57:45 UTC 2023


On Tue, 19 Sep 2023 07:33:11 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments changes
>
> test/jdk/javax/swing/JTree/bug4696499.java line 49:
> 
>> 47:         try {
>> 48:             SwingUtilities.invokeAndWait(() -> {
>> 49:                 fr = new JFrame("bug4696499");
> 
> I guess frame is not needed and can be made headless

Test is now headless. Thanks!

> test/jdk/javax/swing/JViewport/bug4546474.java line 50:
> 
>> 48:         try {
>> 49:             SwingUtilities.invokeAndWait(() -> {
>> 50:                 fr = new JFrame("bug4546474");
> 
> Guess this also can be made headless without frame

Test is now headless. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15802#discussion_r1330634913
PR Review Comment: https://git.openjdk.org/jdk/pull/15802#discussion_r1330634987


More information about the client-libs-dev mailing list