RFR: 8315825: Open some swing tests
Abhishek Kumar
abhiscxk at openjdk.org
Wed Sep 20 05:51:45 UTC 2023
On Wed, 20 Sep 2023 00:57:57 GMT, Alisen Chung <achung at openjdk.org> wrote:
> Opening some swing tests:
> 1 javax/swing/LayoutComparator/4907772/bug4907772.java
> 2 javax/swing/LayoutComparator/4979794/bug4979794.java
> 3 javax/swing/LegacyGlueFocusTraversalPolicy/4765272/bug4765272.java
> 4 javax/swing/RootPaneChecking/RootPaneChecking.java
test/jdk/javax/swing/JComponent/bug4765272.java line 24:
> 22: */
> 23:
> 24: /* @test
Suggestion:
/*
* @test
To maintain consistency across all tests. Applies to other tests as well.
test/jdk/javax/swing/JComponent/bug4765272.java line 43:
> 41:
> 42: public class bug4765272 {
> 43: static boolean focusGained = false;
volatile?
test/jdk/javax/swing/JComponent/bug4765272.java line 109:
> 107: Robot r = new Robot();
> 108: r.delay(1000);
> 109: r.waitForIdle();
waitForIdle before delay
test/jdk/javax/swing/JComponent/bug4979794.java line 71:
> 69: Robot r = new Robot();
> 70: r.delay(1000);
> 71: r.waitForIdle();
waitForIdle before delay
test/jdk/javax/swing/JComponent/bug4979794.java line 79:
> 77: Component next2 = policy.getComponentAfter(fr, btn2);
> 78: if (next1 == next2) {
> 79: throw new Error("btn1 and btn2 have the same next Component.");
`RuntimeException` instead of `Error`?
test/jdk/javax/swing/JPanel/bug4907772.java line 70:
> 68: Robot r = new Robot();
> 69: r.delay(1000);
> 70: r.waitForIdle();
waitForIdle before delay
test/jdk/javax/swing/RootPaneChecking/RootPaneChecking.java line 45:
> 43: public static void main(String[] args) throws Exception {
> 44: SwingUtilities.invokeAndWait(() -> {
> 45: MyJFrame frame = new MyJFrame();
Title can be added.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15830#discussion_r1331023318
PR Review Comment: https://git.openjdk.org/jdk/pull/15830#discussion_r1331024924
PR Review Comment: https://git.openjdk.org/jdk/pull/15830#discussion_r1331025553
PR Review Comment: https://git.openjdk.org/jdk/pull/15830#discussion_r1331026964
PR Review Comment: https://git.openjdk.org/jdk/pull/15830#discussion_r1331027687
PR Review Comment: https://git.openjdk.org/jdk/pull/15830#discussion_r1331028207
PR Review Comment: https://git.openjdk.org/jdk/pull/15830#discussion_r1331030956
More information about the client-libs-dev
mailing list