RFR: 8316285: Opensource JButton manual tests [v2]

[Prasanta Sadhukhan]

On Wed, 20 Sep 2023 05:58:11 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few closed JButton swing manual test converted to automated and open sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unused robot instance

Changes requested by psadhukhan (Reviewer).

test/jdk/javax/swing/JButton/bug4234034.java line 2:

> 1: /*
> 2:  * Copyright (c) 2000, 2023 Oracle and/or its affiliates. All rights reserved.

should be 1999 and a "," after 2023 else validate-source probably will fail, you can check mach5 -j tier1

test/jdk/javax/swing/JButton/bug4234034.java line 27:

> 25:  * @test
> 26:  * @bug 4234034
> 27:  * @summary Tests

add proper summary

test/jdk/javax/swing/JButton/bug4234034.java line 47:

> 45:         try {
> 46:             SwingUtilities.invokeAndWait(() -> {
> 47:                     frame = new JFrame("bug4323121");

seems like indent is wrong

test/jdk/javax/swing/JButton/bug4234034.java line 52:

> 50:                     frame.getContentPane().add(button);
> 51:                     frame.pack();
> 52:                     frame.setSize(250, 200);

pack and setSize together doesn't make sense...Use one or the other, probably pack will do...

test/jdk/javax/swing/JButton/bug4234034.java line 64:

> 62:             robot.keyPress(KeyEvent.VK_F1);
> 63:             robot.keyRelease(KeyEvent.VK_F1);
> 64:             robot.keyRelease(KeyEvent.VK_CONTROL);

there is no failure check...what should happen with ctrl+F1 without the fix, will it crash?

test/jdk/javax/swing/JButton/bug4323121.java line 2:

> 1: /*
> 2:  * Copyright (c) 2000, 2023 Oracle and/or its affiliates. All rights reserved.

a "," after 2023

test/jdk/javax/swing/JButton/bug4323121.java line 61:

> 59:                 frame.getContentPane().add(button);
> 60:                 frame.pack();
> 61:                 frame.setSize(250, 200);

try either pack or setSize

test/jdk/javax/swing/JButton/bug4323121.java line 74:

> 72:             });
> 73:             robot.mouseMove(pt.x + buttonW / 2, pt.y + buttonH / 2);
> 74: 

better to use waitForIdle here

test/jdk/javax/swing/JButton/bug4490179.java line 2:

> 1: /*
> 2:  * Copyright (c) 2002, 2023 Oracle and/or its affiliates. All rights reserved.

a "," after 2023

test/jdk/javax/swing/JButton/bug4490179.java line 48:

> 46:     static volatile int buttonH;
> 47:     static volatile boolean passed = true;
> 48:     public static void main(String[] args) throws Exception {

give 1 line gap before main

test/jdk/javax/swing/JButton/bug4490179.java line 62:

> 60:                 });
> 61:                 frame.pack();
> 62:                 frame.setSize(250, 200);

use pack or setSize

test/jdk/javax/swing/JButton/bug4490179.java line 76:

> 74: 
> 75:             robot.mouseMove(pt.x + buttonW / 2, pt.y + buttonH / 2);
> 76:             robot.delay(100);

no need of this delay as setAutpDelay is there, you can put waitForIdle instead..

-------------

PR Review: https://git.openjdk.org/jdk/pull/15835#pullrequestreview-1634733934
PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331048251
PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331048424
PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331048803
PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331049402
PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331051365
PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331051901
PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331052458
PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331053098
PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331054487
PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331055384
PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331056330
PR Review Comment: https://git.openjdk.org/jdk/pull/15835#discussion_r1331057714