RFR: 8315742: Open source several Swing Scroll related tests

[Damon Nguyen]

On Wed, 20 Sep 2023 09:38:19 GMT, Tejesh R <tr at openjdk.org> wrote:

> Open sourcing these Swing Scroll related tests:
> 
> javax/swing/JScrollBar/4495822/bug4495822.java
> javax/swing/JScrollBar/4696826/bug4696826.java
> javax/swing/JScrollBar/4842792/bug4842792.java
> javax/swing/JScrollPane/4247092/bug4247092.java
> javax/swing/JScrollPane/4264640/bug4264640.java
> javax/swing/JScrollPane/4467063/bug4467063.java

LGTM after the minor changes suggested.

test/jdk/javax/swing/JScrollBar/bug4495822.java line 60:

> 58:             throw new RuntimeException("adjustmentValueChanged() not invoked!");
> 59:         }
> 60:         System.out.println("test Passed!");

Suggestion:

        System.out.println("Test Passed!");

test/jdk/javax/swing/JScrollBar/bug4696826.java line 40:

> 38: 
> 39: public class bug4696826 {
> 40:     public static void main(String[] argv) throws Exception {

Suggestion:

    public static void main(String[] args) throws Exception {

test/jdk/javax/swing/JScrollBar/bug4696826.java line 55:

> 53:             sb.paint(g);
> 54:         });
> 55:         System.out.println("test Passed!");

Suggestion:

        System.out.println("Test Passed!");

test/jdk/javax/swing/JScrollBar/bug4842792.java line 40:

> 38:     public static TestScrollBar scrollBar;
> 39: 
> 40:     public static void main(String[] argv) throws Exception {

Suggestion:

    public static void main(String[] args) throws Exception {

test/jdk/javax/swing/JScrollBar/bug4842792.java line 50:

> 48:             }
> 49:         });
> 50:         System.out.println("test Passed!");

Suggestion:

        System.out.println("Test Passed!");

test/jdk/javax/swing/JScrollBar/bug4842792.java line 65:

> 63:                                            MouseEvent.BUTTON1_DOWN_MASK,
> 64:                                            150, 10,
> 65:                                            1, true);

I see you're making a newline per argument, but here you start a newline after 2 since these arguments are shorter. I think it's OK to put all 4 in one line if you're doing this already.
Suggestion:

                                           150, 10, 1, true);

test/jdk/javax/swing/JScrollPane/bug4247092.java line 40:

> 38:             throw new RuntimeException("The corner component should be null");
> 39:         }
> 40:         System.out.println("test Passed!");

Suggestion:

        System.out.println("Test Passed!");

test/jdk/javax/swing/JScrollPane/bug4264640.java line 79:

> 77:             });
> 78:         }
> 79:         System.out.println("test Passed!");

Suggestion:

        System.out.println("Test Passed!");

test/jdk/javax/swing/JScrollPane/bug4467063.java line 96:

> 94:             }
> 95:         });
> 96:         System.out.println("test Passed!");

Suggestion:

        System.out.println("Test Passed!");

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15839#pullrequestreview-1636070878
PR Review Comment: https://git.openjdk.org/jdk/pull/15839#discussion_r1331893608
PR Review Comment: https://git.openjdk.org/jdk/pull/15839#discussion_r1331894728
PR Review Comment: https://git.openjdk.org/jdk/pull/15839#discussion_r1331894443
PR Review Comment: https://git.openjdk.org/jdk/pull/15839#discussion_r1331895496
PR Review Comment: https://git.openjdk.org/jdk/pull/15839#discussion_r1331895776
PR Review Comment: https://git.openjdk.org/jdk/pull/15839#discussion_r1331897823
PR Review Comment: https://git.openjdk.org/jdk/pull/15839#discussion_r1331898300
PR Review Comment: https://git.openjdk.org/jdk/pull/15839#discussion_r1331899239
PR Review Comment: https://git.openjdk.org/jdk/pull/15839#discussion_r1331900936