RFR: 8311922: [macOS] right-Option key fails to generate release event [v5]

Phil Race prr at openjdk.org
Wed Sep 20 18:34:44 UTC 2023


On Wed, 30 Aug 2023 18:23:11 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Previously, a new key combination involving the option key was added to Aqua LAF for JTextAreas. In doing so, some code was removed that created this regression. The regression caused the right option key on Mac OS to incorrectly show another KeyPressed event instead of a KeyReleased event when pressing and releasing the key. Additionally, the location of the key was 'standard' instead of 'right'. Adding back the key mask and its following code resolves the issue and doesn't cause any other CI tests to fail.
>> 
>> The headful test included displays the key events as they're pressed. After the changes, the test correctly shows the right option key's KeyPressed and KeyReleased events and shows the location as 'right'.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Modified test for easier use

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/15432#pullrequestreview-1636272397


More information about the client-libs-dev mailing list