RFR: 8316627: JViewport Test headless failure [v3]

Phil Race prr at openjdk.org
Wed Sep 20 21:55:41 UTC 2023


On Wed, 20 Sep 2023 21:52:37 GMT, Phil Race <prr at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove size
>
> test/jdk/javax/swing/JViewport/bug4546474.java line 51:
> 
>> 49:         if (!viewChanged) {
>> 50:             viewChanged = true;
>> 51:         }
> 
> What purpose does viewChanged have ?
> Its set but never read.

The adjustmentListener therefore seems irrelevant too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15847#discussion_r1332220853


More information about the client-libs-dev mailing list