RFR: 8316627: JViewport Test headless failure [v4]

Phil Race prr at openjdk.org
Wed Sep 20 22:17:45 UTC 2023


On Wed, 20 Sep 2023 22:03:22 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Converted test needs headful tag added to avoid failures.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove viewChanged

Looks OK now. You can fix the statics if you like.

test/jdk/javax/swing/JViewport/bug4546474.java line 37:

> 35: public class bug4546474 {
> 36:     static JScrollPane scrollpane;
> 37:     static JScrollBar sbar;

These two static vars can be local - you don't need to re-test, after that, just make sure it compiles.

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15847#pullrequestreview-1636575801
PR Review Comment: https://git.openjdk.org/jdk/pull/15847#discussion_r1332228179


More information about the client-libs-dev mailing list