RFR: 8316240: Open source several add/remove MenuBar manual tests [v2]

Alexander Zvegintsev azvegint at openjdk.org
Thu Sep 21 14:03:41 UTC 2023


On Wed, 20 Sep 2023 05:08:50 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix imports
>
> test/jdk/java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_4.java line 59:
> 
>> 57: 
>> 58:             After a menubar has been replaced with another menubar,
>> 59:             the frame should not be resized nor repositioned on the screen.
> 
> Can we not automate it? I mean we can do the click by robot and then check frame.getSize and getLocationOnScreen before and after click, no?
> 
> Probably applicable for all tests which tests "frame  should not be resized nor repositioned on the screen"

We also have to control the MenuBar display itself, and this will still have a manual part for visual control as it looks different on different systems.
So I'm going to leave this test manual.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15800#discussion_r1333099396


More information about the client-libs-dev mailing list